Skip to content

Do not generate debug info for declarations in system header files#11544

Merged
asudarsa merged 35 commits intointel:syclfrom
LU-JOHN:no-system-debug
Jan 16, 2024
Merged

Do not generate debug info for declarations in system header files#11544
asudarsa merged 35 commits intointel:syclfrom
LU-JOHN:no-system-debug

Conversation

@LU-JOHN
Copy link
Contributor

@LU-JOHN LU-JOHN commented Oct 14, 2023

Add option:

-fno-system-debug Do not emit debug information for declarations in system headers

@LU-JOHN LU-JOHN requested a review from a team as a code owner October 14, 2023 06:13
@LU-JOHN LU-JOHN marked this pull request as draft October 14, 2023 06:13
@LU-JOHN LU-JOHN temporarily deployed to WindowsCILock October 14, 2023 06:43 — with GitHub Actions Inactive
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What happens to template declaration from a system header file, but instantiated in the user file? Are they affected?
  2. Would like to see a few tests for this that shows what would be different for the user.

Lu, John added 15 commits January 8, 2024 11:54
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
… generate debug info

Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
…ase for this change.

Signed-off-by: Lu, John <john.lu@intel.com>
…uarded by a new option.

Signed-off-by: Lu, John <john.lu@intel.com>
…bg info for math library functions.

Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@asudarsa
Copy link
Contributor

Hi @premanandrao

There have been several changes since your latest comment. Can you please take a look when convenient?

Thanks
Sincerely

@LU-JOHN LU-JOHN requested a review from premanandrao January 12, 2024 15:33
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit.

Signed-off-by: Lu, John <john.lu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants